Repository navigation
Preserve caller data for timezone-aware curves - #794
Open
pengpengyi92 wants to merge 1 commit into
Open
pengpengyi92 wants to merge 1 commit into
pengpengyi92 wants to merge 1 commit into
Conversation
Signed-off-by: Pengyi Peng <74917296+pengpengyi92@users.noreply.github.com>
pengpengyi92
requested review from
AdamGlustein,
alexddobkin,
robambalu and
svatasoiu
as code owners
November 14, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a list of timezone-aware ticks is passed to csp.curve, the adapter currently rewrites the caller's list with naive UTC datetimes. Code that reuses the source list loses the original timezone metadata.
Change
Normalize timezone-aware and relative input into adapter-local lists; already naive inputs and the NumPy path are unchanged. The regression reuses the same list across two runs, checks UTC output, and verifies the input still contains the original aware timestamp.
Validation
Python 3.12/Windows with the exact checkout's Python curve module and CSP 0.19.0's published native engine. The new regression fails on main but the four controls pass. All five pass with the patch. No native rebuild or full CI matrix run locally.